s390/pci: Highlight failure to enable PCI function

Emit an error log when a PCI function cannot be enabled for use, despite
being reported as configured to the system.

This brings to attention situations where functions might go missing
without notice. Going unnoticed is less likely when functions are added
to the system through hotplug, but will produce the same error log.

Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

diff --git a/arch/s390/pci/pci_bus.c b/arch/s390/pci/pci_bus.c
index 45a1c36c5a54e3a841e61cc365d3f36e9a94ba50..be8c697fea0cc755cfdb4fb0a9e3b95183bec0dc 100644 (file)
--- a/arch/s390/pci/pci_bus.c
+++ b/arch/s390/pci/pci_bus.c
@@ -45,8 +45,10 @@ static int zpci_bus_prepare_device(struct zpci_dev *zdev)
 
        if (!zdev_enabled(zdev)) {
                rc = zpci_enable_device(zdev);
-               if (rc)
+               if (rc) {
+                       pr_err("Enabling PCI function %08x failed\n", zdev->fid);
                        return rc;
+               }
        }
 
        if (!zdev->has_resources) {