warn and fail if server chose a nickname with illegal characters

svn:r1318

diff --git a/src/or/config.c b/src/or/config.c
index 7434dfd2f32d4f6bb89e3822e15ea2934820fdd4..799eb97966b312634a5addd41ff410167d097950 100644 (file)
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -568,9 +568,15 @@ int getconfig(int argc, char **argv, or_options_t *options) {
     result = -1;
   }
 
-  if(options->ORPort && options->Nickname == NULL) {
-    log_fn(LOG_WARN,"Nickname required if ORPort is set, but not found.");
-    result = -1;
+  if (options->ORPort) {
+    if (options->Nickname == NULL) {
+      log_fn(LOG_WARN,"Nickname required if ORPort is set, but not found.");
+      result = -1;
+    } else if (strspn(options->Nickname, LEGAL_NICKNAME_CHARACTERS) !=
+               strlen(options->Nickname)) {
+      log_fn(LOG_WARN, "Nickname '%s' contains illegal characters.", options->Nickname);
+      result = -1;
+    }
   }
 
   if(options->ORPort) { /* get an IP for ourselves */