]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ACPICA: events/evxfregn: don't release the ContextMutex that was never acquired
authorDaniil Tatianin <d-tatianin@yandex-team.ru>
Fri, 22 Nov 2024 08:29:54 +0000 (11:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Dec 2024 17:07:21 +0000 (18:07 +0100)
[ Upstream commit c53d96a4481f42a1635b96d2c1acbb0a126bfd54 ]

This bug was first introduced in c27f3d011b08, where the author of the
patch probably meant to do DeleteMutex instead of ReleaseMutex. The
mutex leak was noticed later on and fixed in e4dfe108371, but the bogus
MutexRelease line was never removed, so do it now.

Link: https://github.com/acpica/acpica/pull/982
Fixes: c27f3d011b08 ("ACPICA: Fix race in generic_serial_bus (I2C) and GPIO op_region parameter handling")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Link: https://patch.msgid.link/20241122082954.658356-1-d-tatianin@yandex-team.ru
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/acpica/evxfregn.c

index b1ff0a8f9c14fe3672c84893d20c948b86b0b695..7672d70da850dd388a261cdbb48479ad9a0705ef 100644 (file)
@@ -201,8 +201,6 @@ acpi_remove_address_space_handler(acpi_handle device,
 
                        /* Now we can delete the handler object */
 
-                       acpi_os_release_mutex(handler_obj->address_space.
-                                             context_mutex);
                        acpi_ut_remove_reference(handler_obj);
                        goto unlock_and_exit;
                }