]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: versaclock3: convert from divider_round_rate() to divider_determine_rate()
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:39 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:26 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: 9e3372b2ebac ("clk: versaclock3: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/clk-versaclock3.c

index 1849863dbd673f3b133b9a295dc608ea43931de6..27b6cf70f3ae1bff1264933d8bac4ccc65481a1c 100644 (file)
@@ -523,11 +523,8 @@ static int vc3_div_determine_rate(struct clk_hw *hw,
                return 0;
        }
 
-       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
-                                      div_data->table,
-                                      div_data->width, div_data->flags);
-
-       return 0;
+       return divider_determine_rate(hw, req, div_data->table, div_data->width,
+                                     div_data->flags);
 }
 
 static int vc3_div_set_rate(struct clk_hw *hw, unsigned long rate,