]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: rcar_canfd: Use of_get_available_child_by_name()
authorBiju Das <biju.das.jz@bp.renesas.com>
Thu, 17 Apr 2025 05:43:04 +0000 (06:43 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 21 May 2025 12:31:23 +0000 (14:31 +0200)
Simplify rcar_canfd_probe() using of_get_available_child_by_name().

While at it, move of_node_put(child) inside the if block to avoid
additional check if of_child is NULL.

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Link: https://patch.msgid.link/20250417054320.14100-4-biju.das.jz@bp.renesas.com
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/rcar/rcar_canfd.c

index aa3df0d05b853b22e1d40978be7f8ab305fb1c8a..2d9569fd0e0b6c22f1bfd1728a726d220c865645 100644 (file)
@@ -1855,13 +1855,13 @@ static int rcar_canfd_probe(struct platform_device *pdev)
 
        for (i = 0; i < info->max_channels; ++i) {
                name[7] = '0' + i;
-               of_child = of_get_child_by_name(dev->of_node, name);
-               if (of_child && of_device_is_available(of_child)) {
+               of_child = of_get_available_child_by_name(dev->of_node, name);
+               if (of_child) {
                        channels_mask |= BIT(i);
                        transceivers[i] = devm_of_phy_optional_get(dev,
                                                        of_child, NULL);
+                       of_node_put(of_child);
                }
-               of_node_put(of_child);
                if (IS_ERR(transceivers[i]))
                        return PTR_ERR(transceivers[i]);
        }