]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c++: adjust comment
authorJason Merrill <jason@redhat.com>
Thu, 13 Jun 2024 01:43:45 +0000 (21:43 -0400)
committerJason Merrill <jason@redhat.com>
Thu, 13 Jun 2024 15:06:14 +0000 (11:06 -0400)
Adjusting the comment I added in r15-1223 to clarify that this is a
workaround for a bug elsewhere.

gcc/cp/ChangeLog:

* module.cc (depset::hash::add_binding_entity): Adjust comment.

gcc/cp/module.cc

index 72e876cec187abc568dc155b8ce5dfb9fef127f1..ea7ad0c1f2915951ae1606327a835955abbd2237 100644 (file)
@@ -13254,9 +13254,10 @@ depset::hash::add_binding_entity (tree decl, WMB_Flags flags, void *data_)
       if (data->hash->add_namespace_entities (decl, data->partitions))
        {
          /* It contains an exported thing, so it is exported.
-            We used to assert DECL_MODULE_PURVIEW_P, but that fails for a
-            namespace like std::__exception_ptr which is never opened in
-            module purview; the exporting using finds another using.  */
+
+            FIXME we have to set DECL_MODULE_PURVIEW_P instead of asserting
+            that it is already set because of the c++/114683 issue with
+            exported using-declarations; see do_nonmember_using_decl.  */
          DECL_MODULE_PURVIEW_P (decl) = true;
          DECL_MODULE_EXPORT_P (decl) = true;
        }