]> git.ipfire.org Git - thirdparty/libnftnl.git/commitdiff
tests: stricter string attribute validation
authorPablo Neira Ayuso <pablo@netfilter.org>
Wed, 15 Jun 2016 11:41:06 +0000 (13:41 +0200)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 15 Jun 2016 11:46:06 +0000 (13:46 +0200)
In nft-expr_lookup-test.c, check for the strings instead of size.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
tests/nft-expr_lookup-test.c

index 83fa829814f6199679c1fbe739d6f5696d7f2904..d3b45df4dc634393c4e80e3b51e0f0fc6fa4a95c 100644 (file)
@@ -30,18 +30,15 @@ static void print_err(const char *msg)
 static void cmp_nftnl_expr(struct nftnl_expr *rule_a,
                              struct nftnl_expr *rule_b)
 {
-       uint32_t data_lena, data_lenb;
-
        if (nftnl_expr_get_u32(rule_a, NFTNL_EXPR_LOOKUP_SREG) !=
            nftnl_expr_get_u32(rule_b, NFTNL_EXPR_LOOPUP_SREG))
                print_err("Expr NFTNL_EXPR_LOOkUP_SREG mismatches");
        if (nftnl_expr_get_u32(rule_a, NFTNL_EXPR_LOOKUP_DREG) !=
            nftnl_expr_get_u32(rule_b, NFTNL_EXPR_LOOPUP_DREG))
                print_err("Expr NFTNL_EXPR_LOOkUP_DREG mismatches");
-       nftnl_expr_get(rule_a, NFTNL_EXPR_LOOKUP_SET, &data_lena);
-       nftnl_expr_get(rule_b, NFTNL_EXPR_LOOKUP_SET, &data_lenb);
-       if (data_lena != data_lenb)
-               print_err("Expr NFTNL_EXPR_LOOKUP_SET size mismatches");
+       if (strcmp(nftnl_expr_get_str(rule_a, NFTNL_EXPR_LOOKUP_SET),
+                  nftnl_expr_get_str(rule_b, NFTNL_EXPR_LOOKUP_SET)))
+               print_err("Expr NFTNL_EXPR_LOOKUP_SET mismatches");
 }
 
 int main(int argc, char *argv[])