]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nss: aiforaf: Drop unused buffer 'port'
authorPeter Krempa <pkrempa@redhat.com>
Wed, 30 Aug 2023 10:19:23 +0000 (12:19 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 4 Sep 2023 08:31:53 +0000 (10:31 +0200)
The 'port' buffer is passed to 'getnameinfo' which is supposed to fill
it but it's not actually later used. Drop the buffer as 'getnameinfo'
allows NULL arguments if they are not needed.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Kristina Hanicova <khanicov@redhat.com>
tools/nss/libvirt_nss.c

index faa44e78df024bd69c9b46f4d289dd94537b3534..37720bf4aea8569a42305e85e4ebf14f643046c1 100644 (file)
@@ -493,7 +493,6 @@ aiforaf(const char *name,
         socklen_t salen;
         void *address = *addrList;
         char host[NI_MAXHOST];
-        char port[NI_MAXSERV];
 
         if (resolved.h_addrtype == AF_INET) {
             sa.sin.sin_family = AF_INET;
@@ -511,7 +510,7 @@ aiforaf(const char *name,
 
         if ((err = getnameinfo(&sa.sa, salen,
                                host, sizeof(host),
-                               port, sizeof(port),
+                               NULL, 0,
                                NI_NUMERICHOST | NI_NUMERICSERV)) != 0) {
             ERROR("Cannot convert socket address to string: %s",
                   gai_strerror(err));