]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
nfs_write_end(): fix handling of short copies
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 6 Sep 2016 01:42:32 +0000 (21:42 -0400)
committerSasha Levin <alexander.levin@verizon.com>
Fri, 13 Jan 2017 01:56:56 +0000 (20:56 -0500)
[ Upstream commit c0cf3ef5e0f47e385920450b245d22bead93e7ad ]

What matters when deciding if we should make a page uptodate is
not how much we _wanted_ to copy, but how much we actually have
copied.  As it is, on architectures that do not zero tail on
short copy we can leave uninitialized data in page marked uptodate.

Cc: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/nfs/file.c

index 8b8d83a526ce2366ae974a87761c9c62c22da7f5..ddf5f9fd719fd3b131efe592e452b49311ea0cfc 100644 (file)
@@ -414,7 +414,7 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
         */
        if (!PageUptodate(page)) {
                unsigned pglen = nfs_page_length(page);
-               unsigned end = offset + len;
+               unsigned end = offset + copied;
 
                if (pglen == 0) {
                        zero_user_segments(page, 0, offset,