]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
power: supply: cros_charge-control: allow start_threshold == end_threshold
authorThomas Weißschuh <linux@weissschuh.net>
Sun, 8 Dec 2024 14:59:27 +0000 (15:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Jan 2025 09:34:23 +0000 (10:34 +0100)
commit e65a1b7fad0e112573eea7d64d4ab4fc513b8695 upstream.

Allow setting the start and stop thresholds to the same value.
There is no reason to disallow it.

Suggested-by: Thomas Koch <linrunner@gmx.net>
Fixes: c6ed48ef5259 ("power: supply: add ChromeOS EC based charge control driver")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
Link: https://lore.kernel.org/r/20241208-cros_charge-control-v2-v1-2-8d168d0f08a3@weissschuh.net
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/cros_charge-control.c

index 58ca6d9ed6132af63a36ea4c5bf212acf066936c..108b121db4423187fb65548396fb9195b8801006 100644 (file)
@@ -139,11 +139,11 @@ static ssize_t cros_chctl_store_threshold(struct device *dev, struct cros_chctl_
                return -EINVAL;
 
        if (is_end_threshold) {
-               if (val <= priv->current_start_threshold)
+               if (val < priv->current_start_threshold)
                        return -EINVAL;
                priv->current_end_threshold = val;
        } else {
-               if (val >= priv->current_end_threshold)
+               if (val > priv->current_end_threshold)
                        return -EINVAL;
                priv->current_start_threshold = val;
        }