]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
test: fix leak of authentication info
authorDaniel P. Berrangé <berrange@redhat.com>
Thu, 5 Mar 2020 15:41:49 +0000 (15:41 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Fri, 6 Mar 2020 13:18:16 +0000 (13:18 +0000)
The 'auths' struct in the test driver was not free()d. This was easy to
miss because the default XML doesn't include auth info.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/test/test_driver.c

index 029d560fb9074e8973657db5446350113efd8a3d..73fe1ad6ce1ae852d80834049ad01d995012036d 100644 (file)
@@ -156,6 +156,7 @@ static void
 testDriverDispose(void *obj)
 {
     testDriverPtr driver = obj;
+    size_t i;
 
     virObjectUnref(driver->caps);
     virObjectUnref(driver->xmlopt);
@@ -165,6 +166,11 @@ testDriverDispose(void *obj)
     virObjectUnref(driver->ifaces);
     virObjectUnref(driver->pools);
     virObjectUnref(driver->eventState);
+    for (i = 0; i < driver->numAuths; i++) {
+        g_free(driver->auths[i].username);
+        g_free(driver->auths[i].password);
+    }
+    g_free(driver->auths);
 }
 
 typedef struct _testDomainNamespaceDef testDomainNamespaceDef;