]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
kconfig: gconf: remove unneeded variables in on_treeview*_button_press_event()
authorMasahiro Yamada <masahiroy@kernel.org>
Tue, 24 Jun 2025 15:05:09 +0000 (00:05 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Tue, 1 Jul 2025 11:07:35 +0000 (20:07 +0900)
Not all position parameters are used here. Passing NULL to
gtk_tree_view_get_cursor() or gtk_tree_view_get_path_at_pos() is
allowed. [1] [2]

[1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L12638
[1]: https://gitlab.gnome.org/GNOME/gtk/-/blob/2.24.33/gtk/gtktreeview.c#L12795

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/gconf.c

index c78eded5c01bd0deeb5c09372b44e9cbe636532f..ab2e0df21037404ca7041d639145704dbd871d83 100644 (file)
@@ -822,13 +822,10 @@ on_treeview2_button_press_event(GtkWidget * widget,
        GtkTreeIter iter;
        struct menu *menu;
        gint col;
-
        gint tx = (gint) event->x;
        gint ty = (gint) event->y;
-       gint cx, cy;
 
-       gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx,
-                                     &cy);
+       gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, NULL, NULL);
        if (path == NULL)
                return FALSE;
 
@@ -871,12 +868,11 @@ on_treeview2_key_press_event(GtkWidget * widget,
 {
        GtkTreeView *view = GTK_TREE_VIEW(widget);
        GtkTreePath *path;
-       GtkTreeViewColumn *column;
        GtkTreeIter iter;
        struct menu *menu;
        gint col;
 
-       gtk_tree_view_get_cursor(view, &path, &column);
+       gtk_tree_view_get_cursor(view, &path, NULL);
        if (path == NULL)
                return FALSE;
 
@@ -930,16 +926,12 @@ on_treeview1_button_press_event(GtkWidget * widget,
 {
        GtkTreeView *view = GTK_TREE_VIEW(widget);
        GtkTreePath *path;
-       GtkTreeViewColumn *column;
        GtkTreeIter iter;
        struct menu *menu;
-
        gint tx = (gint) event->x;
        gint ty = (gint) event->y;
-       gint cx, cy;
 
-       gtk_tree_view_get_path_at_pos(view, tx, ty, &path, &column, &cx,
-                                     &cy);
+       gtk_tree_view_get_path_at_pos(view, tx, ty, &path, NULL, NULL, NULL);
        if (path == NULL)
                return FALSE;