No need for intermediate variable

Also pacifies Coverity (CID #1604602)

diff --git a/src/lib/eap_aka_sim/module.c b/src/lib/eap_aka_sim/module.c
index 4b58fc6d0d803fc119d4df8dc25c89e4be5d25c6..38c66146dc27cb26c9a8bc670d7b9f50603a68a9 100644 (file)
--- a/src/lib/eap_aka_sim/module.c
+++ b/src/lib/eap_aka_sim/module.c
@@ -64,7 +64,6 @@ static unlang_action_t mod_encode(rlm_rcode_t *p_result, module_ctx_t const *mct
        uint8_t const                   *request_hmac_extra = NULL;
        size_t                          request_hmac_extra_len = 0;
        fr_pair_t                       *vp;
-       int                             ret;
 
        /*
         *      If there's no subtype vp, we look at the rcode
@@ -260,8 +259,7 @@ static unlang_action_t mod_encode(rlm_rcode_t *p_result, module_ctx_t const *mct
 
        RDEBUG2("Encoding attributes");
        log_request_pair_list(L_DBG_LVL_2, request, NULL, &request->reply_pairs, NULL);
-       ret = fr_aka_sim_encode(request, &request->reply_pairs, &encode_ctx);
-       if (ret <= 0) RETURN_MODULE_FAIL;
+       if (fr_aka_sim_encode(request, &request->reply_pairs, &encode_ctx) <= 0) RETURN_MODULE_FAIL;
 
        switch (subtype_vp->vp_uint16) {
        case FR_SUBTYPE_VALUE_AKA_IDENTITY: