]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nfc: nxp-nci: remove interrupt trigger type
authorCarl Lee <carl.lee@amd.com>
Thu, 5 Feb 2026 11:11:39 +0000 (19:11 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Feb 2026 04:54:50 +0000 (20:54 -0800)
For NXP NCI devices (e.g. PN7150), the interrupt is level-triggered and
active high, not edge-triggered.

Using IRQF_TRIGGER_RISING in the driver can cause interrupts to fail
to trigger correctly.

Remove IRQF_TRIGGER_RISING and rely on the IRQ trigger type configured
via Device Tree.

Signed-off-by: Carl Lee <carl.lee@amd.com>
Link: https://patch.msgid.link/20260205-fc-nxp-nci-remove-interrupt-trigger-type-v2-1-79d2ed4a7e42@amd.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/nfc/nxp-nci/i2c.c

index 049662ffdf972982d79ee8242a88cfb0a078cb13..6a5ce8ff91f0b58ca3a8c81d80cf6c9084818de9 100644 (file)
@@ -305,7 +305,7 @@ static int nxp_nci_i2c_probe(struct i2c_client *client)
 
        r = request_threaded_irq(client->irq, NULL,
                                 nxp_nci_i2c_irq_thread_fn,
-                                IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+                                IRQF_ONESHOT,
                                 NXP_NCI_I2C_DRIVER_NAME, phy);
        if (r < 0)
                nfc_err(&client->dev, "Unable to register IRQ handler\n");