]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: dw_mmc: Remove dma_ops from struct dw_mci_board
authorShawn Lin <shawn.lin@rock-chips.com>
Tue, 6 Jan 2026 02:16:53 +0000 (10:16 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 23 Feb 2026 11:06:54 +0000 (12:06 +0100)
It does take dma_ops from struct dw_mci_board, but we immediately
re-assign it from either dw_mci_idmac_ops or dw_mci_edmac_ops in
dw_mci_init_dma(). That means it's never used now, or has been
broken for a long time without noticed. It seems no drivers need
it, so remove it now.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc.c
drivers/mmc/host/dw_mmc.h

index e437a142a76e6ec7b2e9912170b073d74a4fc58f..4d4a727b8b3f35cbdb6e41f025ed45be5fe8cfd2 100644 (file)
@@ -3366,7 +3366,6 @@ int dw_mci_probe(struct dw_mci *host)
                goto err_clk_ciu;
        }
 
-       host->dma_ops = host->pdata->dma_ops;
        dw_mci_init_dma(host);
 
        /* Clear the interrupts for the host controller */
index 26efe1a8a41bd4f4179d6a91b5bac49a20625478..bf3566ac40d970f25a10c5a27a1f5029086cb26d 100644 (file)
@@ -78,7 +78,7 @@ struct dw_mci_dma_slave {
  * @dma_64bit_address: Whether DMA supports 64-bit address mode or not.
  * @sg_dma: Bus address of DMA buffer.
  * @sg_cpu: Virtual address of DMA buffer.
- * @dma_ops: Pointer to platform-specific DMA callbacks.
+ * @dma_ops: Pointer to DMA callbacks.
  * @cmd_status: Snapshot of SR taken upon completion of the current
  * @ring_size: Buffer size for idma descriptors.
  *     command. Only valid when EVENT_CMD_COMPLETE is pending.
@@ -280,7 +280,6 @@ struct dw_mci_board {
        u32 detect_delay_ms;
 
        struct reset_control *rstc;
-       struct dw_mci_dma_ops *dma_ops;
 };
 
 /* Support for longer data read timeout */