]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: sdhci-cadence: use of_property_present
authorBenoît Monin <benoit.monin@bootlin.com>
Thu, 26 Jun 2025 14:43:31 +0000 (16:43 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 3 Jul 2025 11:30:34 +0000 (13:30 +0200)
Instead of using of_property_read_bool to check the presence of the
cdns,phy-* properties in the device tree, use of_property_present in
function sdhci_cdns_phy_param_count.

This silences the following warning messages since the cdns,phy-*
properties are all u32, not boolean.

OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-legacy' with a value.
OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-mmc-highspeed' with a value.
OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-input-delay-mmc-ddr' with a value.
OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-dll-delay-sdclk' with a value.
OF: /soc/sdhci@d8010000: Read of boolean property 'cdns,phy-dll-delay-sdclk-hsmmc' with a value.

Signed-off-by: Benoît Monin <benoit.monin@bootlin.com>
Link: https://lore.kernel.org/r/e244c1377f7b2ad5d026c9d9368a08de3887129f.1750943549.git.benoit.monin@bootlin.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci-cadence.c

index e443beed166f2ef7679c2d53aa3a955f4bcc494d..2d823e158c59844dc7916db6a1d6e3d8b02ea5a0 100644 (file)
@@ -144,7 +144,7 @@ static unsigned int sdhci_cdns_phy_param_count(struct device_node *np)
        int i;
 
        for (i = 0; i < ARRAY_SIZE(sdhci_cdns_phy_cfgs); i++)
-               if (of_property_read_bool(np, sdhci_cdns_phy_cfgs[i].property))
+               if (of_property_present(np, sdhci_cdns_phy_cfgs[i].property))
                        count++;
 
        return count;