bridge_simple: Suppress unchanged topology change requests

In simple_bridge_join, we were sending topology change requests
even when the new and old topologies were the same.  In some
circumstances, this can cause unnecessary re-invites and even
a re-invite flood.  We now suppress those.

Resolves: #384

diff --git a/bridges/bridge_simple.c b/bridges/bridge_simple.c
index ba300ed4d3f9520c073b20c80062921cf33a0166..4e27b9f5409211da4af7f87556adedee3b512b0c 100644 (file)
--- a/bridges/bridge_simple.c
+++ b/bridges/bridge_simple.c
@@ -181,7 +181,14 @@ static int simple_bridge_join(struct ast_bridge *bridge, struct ast_bridge_chann
                return 0;
        }
 
-       ast_channel_request_stream_topology_change(c1, new_top, &simple_bridge);
+       if (!ast_stream_topology_equal(new_top, existing_top)) {
+               ast_channel_request_stream_topology_change(c1, new_top, &simple_bridge);
+       } else {
+               ast_debug(3, "%s: Topologies already match. Current: %s  Requested: %s\n",
+                               ast_channel_name(c1),
+                               ast_str_tmp(256, ast_stream_topology_to_str(existing_top, &STR_TMP)),
+                               ast_str_tmp(256, ast_stream_topology_to_str(new_top, &STR_TMP)));
+       }
        ast_stream_topology_free(new_top);
 
        return 0;