]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: cadence-hpa: Add post-link delay
authorHans Zhang <18255117159@163.com>
Mon, 18 May 2026 00:42:42 +0000 (08:42 +0800)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 23 Jun 2026 19:33:48 +0000 (14:33 -0500)
The Cadence HPA (High Performance Architecture IP) specific link setup
function cdns_pcie_hpa_host_link_setup() waits for the link to come up
but does not implement the required 100 ms delay after link training
completes for speeds > 5.0 GT/s (PCIe r6.0 sec 6.6.1).

Add a call to pci_host_common_link_train_delay() immediately after the
link is confirmed to be up, using the max_link_speed field. Also, in the
HPA host setup function, read the device tree property "max-link-speed"
to initialize max_link_speed if not already set by a glue driver.

This ensures compliance for HPA-based platforms.

Signed-off-by: Hans Zhang <18255117159@163.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
[bhelgaas: driver tag "cadence: HPA:" -> "cadence-hpa:"]
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20260518004246.1384532-4-18255117159@163.com
drivers/pci/controller/cadence/pcie-cadence-host-hpa.c

index 0f540bed58e8887f13b9dd0e905eb036a06db2ff..8ef58ed01daaa276eb158ecefe03893f0d351d65 100644 (file)
@@ -15,6 +15,8 @@
 
 #include "pcie-cadence.h"
 #include "pcie-cadence-host-common.h"
+#include "../pci-host-common.h"
+#include "../../pci.h"
 
 static u8 bar_aperture_mask[] = {
        [RP_BAR0] = 0x3F,
@@ -304,6 +306,8 @@ int cdns_pcie_hpa_host_link_setup(struct cdns_pcie_rc *rc)
        ret = cdns_pcie_host_wait_for_link(pcie, cdns_pcie_hpa_link_up);
        if (ret)
                dev_dbg(dev, "PCIe link never came up\n");
+       else
+               pci_host_common_link_train_delay(pcie->max_link_speed);
 
        return ret;
 }
@@ -313,6 +317,7 @@ int cdns_pcie_hpa_host_setup(struct cdns_pcie_rc *rc)
 {
        struct device *dev = rc->pcie.dev;
        struct platform_device *pdev = to_platform_device(dev);
+       struct device_node *np = dev->of_node;
        struct pci_host_bridge *bridge;
        enum   cdns_pcie_rp_bar bar;
        struct cdns_pcie *pcie;
@@ -343,6 +348,9 @@ int cdns_pcie_hpa_host_setup(struct cdns_pcie_rc *rc)
                rc->cfg_res = res;
        }
 
+       if (pcie->max_link_speed < 1)
+               pcie->max_link_speed = of_pci_get_max_link_speed(np);
+
        /* Put EROM Bar aperture to 0 */
        cdns_pcie_hpa_writel(pcie, REG_BANK_IP_CFG_CTRL_REG, CDNS_PCIE_EROM, 0x0);