]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: rockchip: Fix Wvoid-pointer-to-enum-cast warning (again)
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 3 Dec 2025 14:16:45 +0000 (15:16 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 3 Dec 2025 14:54:38 +0000 (14:54 +0000)
'version' is an enum, thus cast of pointer on 64-bit compile test with
clang W=1 causes:

  rockchip_pdm.c:583:17: error: cast to smaller integer type 'enum rk_pdm_version' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

This was already fixed in commit 49a4a8d12612 ("ASoC: rockchip: Fix
Wvoid-pointer-to-enum-cast warning") but then got bad in
commit 9958d85968ed ("ASoC: Use device_get_match_data()").

Discussion on LKML also pointed out that 'uintptr_t' is not the correct
type and either 'kernel_ulong_t' or 'unsigned long' should be used,
with several arguments towards the latter [1].

Link: https://lore.kernel.org/r/CAMuHMdX7t=mabqFE5O-Cii3REMuyaePHmqX+j_mqyrn6XXzsoA@mail.gmail.com/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251203141644.106459-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_pdm.c

index c1ee470ec6079df8f9f9a60c3d143f2ed4bfd6d9..c69cdd6f24994ca5ecbf6d29b926cbcd1f693b33 100644 (file)
@@ -580,7 +580,7 @@ static int rockchip_pdm_probe(struct platform_device *pdev)
        if (!pdm)
                return -ENOMEM;
 
-       pdm->version = (enum rk_pdm_version)device_get_match_data(&pdev->dev);
+       pdm->version = (unsigned long)device_get_match_data(&pdev->dev);
        if (pdm->version == RK_PDM_RK3308) {
                pdm->reset = devm_reset_control_get(&pdev->dev, "pdm-m");
                if (IS_ERR(pdm->reset))