]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Report error on unexpected job stats type
authorJiri Denemark <jdenemar@redhat.com>
Fri, 1 Jun 2018 08:22:30 +0000 (10:22 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Thu, 28 Jun 2018 13:27:59 +0000 (15:27 +0200)
If we ever fail to properly set jobinfo->statsType,
qemuDomainJobInfoToParams would return -1 without setting an error.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_domain.c

index fee44812c11dbbb26c6abcd7b7ce27b15de05c39..9afe70592983c29c605a435704ea1c8f57a2d4de 100644 (file)
@@ -730,6 +730,12 @@ qemuDomainJobInfoToParams(qemuDomainJobInfoPtr jobInfo,
         return qemuDomainDumpJobInfoToParams(jobInfo, type, params, nparams);
 
     case QEMU_DOMAIN_JOB_STATS_TYPE_NONE:
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                       _("invalid job statistics type"));
+        break;
+
+    default:
+        virReportEnumRangeError(qemuDomainJobStatsType, jobInfo->statsType);
         break;
     }