]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: imx-pxp: Fix ERR_PTR dereference in pxp_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Tue, 14 May 2024 09:50:38 +0000 (02:50 -0700)
committerLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 26 Jun 2024 06:14:02 +0000 (09:14 +0300)
devm_regmap_init_mmio() can fail, add a check and bail out in case of
error.

Fixes: 4e5bd3fdbeb3 ("media: imx-pxp: convert to regmap")
Cc: stable@vger.kernel.org
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20240514095038.3464191-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
drivers/media/platform/nxp/imx-pxp.c

index e62dc5c1a4aeaed041bb30ac67a919c26a1ac289..e4427e6487fba763acdfc0e1535431ef33116c0f 100644 (file)
@@ -1805,6 +1805,9 @@ static int pxp_probe(struct platform_device *pdev)
                return PTR_ERR(mmio);
        dev->regmap = devm_regmap_init_mmio(&pdev->dev, mmio,
                                            &pxp_regmap_config);
+       if (IS_ERR(dev->regmap))
+               return dev_err_probe(&pdev->dev, PTR_ERR(dev->regmap),
+                                    "Failed to init regmap\n");
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)