]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Remove dead code
authorMark Andrews <marka@isc.org>
Mon, 18 Jul 2022 07:39:12 +0000 (17:39 +1000)
committerMark Andrews <marka@isc.org>
Tue, 6 Sep 2022 12:47:08 +0000 (12:47 +0000)
    *** CID 352816:  Control flow issues  (DEADCODE) /lib/ns/query.c: 8443 in query_dns64()
    8437     cleanup:
    8438      if (buffer != NULL) {
    8439      isc_buffer_free(&buffer);
    8440      }
    8441
    8442      if (dns64_rdata != NULL) {
    >>>     CID 352816:  Control flow issues  (DEADCODE)
    >>>     Execution cannot reach this statement: "dns_message_puttemprdata(cl...".
    8443      dns_message_puttemprdata(client->message, &dns64_rdata);
    8444      }
    8445
    8446      if (dns64_rdataset != NULL) {
    8447      dns_message_puttemprdataset(client->message, &dns64_rdataset);
    8448      }

lib/ns/query.c

index ea676dd537eadec29573a7e496c1d54f286e4e8d..93d2d6c353d56da18dcc4f9821d7effa6cb0905c 100644 (file)
@@ -8324,10 +8324,6 @@ cleanup:
                isc_buffer_free(&buffer);
        }
 
-       if (dns64_rdata != NULL) {
-               dns_message_puttemprdata(client->message, &dns64_rdata);
-       }
-
        if (dns64_rdataset != NULL) {
                dns_message_puttemprdataset(client->message, &dns64_rdataset);
        }