]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
r8152: fix writing USB_BP2_EN
authorHayes Wang <hayeswang@realtek.com>
Thu, 19 Aug 2021 03:05:36 +0000 (11:05 +0800)
committerSasha Levin <sashal@kernel.org>
Thu, 26 Aug 2021 12:35:11 +0000 (08:35 -0400)
[ Upstream commit a876a33d2a1102f99fc782fefb784f4dd4841d8c ]

The register of USB_BP2_EN is 16 bits, so we should use
ocp_write_word(), not ocp_write_byte().

Fixes: 9370f2d05a2a ("support request_firmware for RTL8153")
Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/r8152.c

index 2cf763b4ea84fc1030e9eecd275ba54d6dabdfa4..b2b77edf72b8ee9793e5f09f565aceabefbd541b 100644 (file)
@@ -3963,7 +3963,7 @@ static void rtl_clear_bp(struct r8152 *tp, u16 type)
        case RTL_VER_15:
        default:
                if (type == MCU_TYPE_USB) {
-                       ocp_write_byte(tp, MCU_TYPE_USB, USB_BP2_EN, 0);
+                       ocp_write_word(tp, MCU_TYPE_USB, USB_BP2_EN, 0);
 
                        ocp_write_word(tp, MCU_TYPE_USB, USB_BP_8, 0);
                        ocp_write_word(tp, MCU_TYPE_USB, USB_BP_9, 0);