event: Check return value from event_notify_null()

event_notify_null() returns int but its return value is not
checked in run_main_loop() and in fwu_mdata tests.
Add proper error checking to all unchecked call sites.

Signed-off-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

diff --git a/common/board_r.c b/common/board_r.c
index 8cf0e14679c05c03d38c482aefe552bcdeedfc45..5d37345ca09d3b2c1ef1f8f4f87e8834b53d062f 100644 (file)
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -569,11 +569,15 @@ static int dm_announce(void)
 
 static int run_main_loop(void)
 {
+       int ret;
+
 #ifdef CONFIG_SANDBOX
        sandbox_main_loop_init();
 #endif
 
-       event_notify_null(EVT_MAIN_LOOP);
+       ret = event_notify_null(EVT_MAIN_LOOP);
+       if (ret)
+               return ret;
 
        /* main_loop() can return to retry autoboot, if so just run it again */
        for (;;)

diff --git a/test/dm/fwu_mdata.c b/test/dm/fwu_mdata.c
index b7680632f95f65f4778d40f77f0c7463aae3591e..643b647af0a9aab7293e5437cb5efd00a846ffdb 100644 (file)
--- a/test/dm/fwu_mdata.c
+++ b/test/dm/fwu_mdata.c
@@ -100,7 +100,7 @@ static int dm_test_fwu_mdata_read(struct unit_test_state *uts)
         * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()
         * to populate g_dev global pointer in that library.
         */
-       event_notify_null(EVT_MAIN_LOOP);
+       ut_assertok(event_notify_null(EVT_MAIN_LOOP));
 
        ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));
        ut_assertok(fwu_init());
@@ -127,7 +127,7 @@ static int dm_test_fwu_mdata_write(struct unit_test_state *uts)
         * Trigger lib/fwu_updates/fwu.c fwu_boottime_checks()
         * to populate g_dev global pointer in that library.
         */
-       event_notify_null(EVT_MAIN_LOOP);
+       ut_assertok(event_notify_null(EVT_MAIN_LOOP));
 
        ut_assertok(uclass_first_device_err(UCLASS_FWU_MDATA, &dev));