]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: report error querying launch params for inactive guest
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 8 Dec 2021 12:51:43 +0000 (07:51 -0500)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 14 Dec 2021 16:04:17 +0000 (16:04 +0000)
Querying launch params on a inactive guest currently triggers
a warning about the monitor being NULL.

https://bugzilla.redhat.com/show_bug.cgi?id=2030437

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_driver.c

index db2b25adbdac7f23f7493c24474120c71b90ffd0..413f62c85fb4cf4da58a53b95c5dff410181bc45 100644 (file)
@@ -19975,6 +19975,12 @@ qemuDomainGetSEVMeasurement(virQEMUDriver *driver,
     if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0)
         return -1;
 
+    if (!virDomainObjIsActive(vm)) {
+        virReportError(VIR_ERR_OPERATION_INVALID,
+                       "%s", _("domain is not running"));
+        goto endjob;
+    }
+
     qemuDomainObjEnterMonitor(driver, vm);
     tmp = qemuMonitorGetSEVMeasurement(QEMU_DOMAIN_PRIVATE(vm)->mon);