]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
gpio: cs5535: use new line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 10 Mar 2025 12:40:27 +0000 (13:40 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 17 Mar 2025 07:27:41 +0000 (08:27 +0100)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250310-gpiochip-set-conversion-v1-13-03798bb833eb@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-cs5535.c

index 6da3a247614a1fe5c3d4f5f480868462b56f99eb..143d1f4173a655b121a4ee3f7b4d846447845af8 100644 (file)
@@ -232,12 +232,14 @@ static int chip_gpio_get(struct gpio_chip *chip, unsigned offset)
        return cs5535_gpio_isset(offset, GPIO_READ_BACK);
 }
 
-static void chip_gpio_set(struct gpio_chip *chip, unsigned offset, int val)
+static int chip_gpio_set(struct gpio_chip *chip, unsigned int offset, int val)
 {
        if (val)
                cs5535_gpio_set(offset, GPIO_OUTPUT_VAL);
        else
                cs5535_gpio_clear(offset, GPIO_OUTPUT_VAL);
+
+       return 0;
 }
 
 static int chip_direction_input(struct gpio_chip *c, unsigned offset)
@@ -294,7 +296,7 @@ static struct cs5535_gpio_chip cs5535_gpio_chip = {
                .request = chip_gpio_request,
 
                .get = chip_gpio_get,
-               .set = chip_gpio_set,
+               .set_rv = chip_gpio_set,
 
                .direction_input = chip_direction_input,
                .direction_output = chip_direction_output,