]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect: fix overflow for files protocol
authorPhilippe Antoine <pantoine@oisf.net>
Wed, 15 Jan 2025 19:59:12 +0000 (20:59 +0100)
committerVictor Julien <victor@inliniac.net>
Mon, 7 Apr 2025 04:57:45 +0000 (06:57 +0200)
CID 1640392

Would happen only if we reached 15 protocols handling files

src/detect-parse.c

index 60d202d6b7fd991f035510e276b6f5c3b02bd169..7bc4ae0d6f94a30ca7a42a87b85f0b045de00b92 100644 (file)
@@ -119,7 +119,9 @@ void DetectFileRegisterProto(
     al_protocols[i].direction = direction;
     al_protocols[i].to_client_progress = to_client_progress;
     al_protocols[i].to_server_progress = to_server_progress;
-    al_protocols[i + 1].alproto = ALPROTO_UNKNOWN;
+    if (i + 1 < ALPROTO_WITHFILES_MAX) {
+        al_protocols[i + 1].alproto = ALPROTO_UNKNOWN;
+    }
 }
 
 void DetectFileRegisterFileProtocols(DetectFileHandlerTableElmt *reg)