Issue #28435: Avoid no_proxy environment variable interfering with tests

Patch by Piotr Szczepaniak.

diff --git a/Lib/test/test_urllib2_localnet.py b/Lib/test/test_urllib2_localnet.py
index 51a95dc43738323f4273829bcdd349d7706ba5a7..9199cb931005f7b4bff8162824fa7f6be5aa2e5b 100644 (file)
--- a/Lib/test/test_urllib2_localnet.py
+++ b/Lib/test/test_urllib2_localnet.py
@@ -329,6 +329,14 @@ class ProxyAuthTests(BaseTestCase):
 
     def setUp(self):
         super(ProxyAuthTests, self).setUp()
+        # Ignore proxy bypass settings in the environment.
+        def restore_environ(old_environ):
+            os.environ.clear()
+            os.environ.update(old_environ)
+        self.addCleanup(restore_environ, os.environ.copy())
+        os.environ['NO_PROXY'] = ''
+        os.environ['no_proxy'] = ''
+
         self.digest_auth_handler = DigestAuthHandler()
         self.digest_auth_handler.set_users({self.USER: self.PASSWD})
         self.digest_auth_handler.set_realm(self.REALM)

diff --git a/Misc/ACKS b/Misc/ACKS
index 9c805b03e681451f71d93bdf134d5cacf8bc2d2f..6d245cd8424cff416d8b1c494606d0c738df0dac 100644 (file)
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -1361,6 +1361,7 @@ Al Sweigart
 Thenault Sylvain
 Péter Szabó
 John Szakmeister
+Piotr Szczepaniak
 Amir Szekely
 Arfrever Frehtes Taifersar Arahesis
 Hideaki Takahashi