]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
vxlan: vnifilter: fix memcpy with u64_stats
authorDavid Yang <mmyangfl@gmail.com>
Tue, 20 Jan 2026 09:21:32 +0000 (17:21 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sun, 25 Jan 2026 21:14:11 +0000 (13:14 -0800)
On 64bit arches, struct u64_stats_sync is empty and provides no help
against load/store tearing. memcpy() should not be considered atomic
against u64 values. Use u64_stats_copy() instead.

Signed-off-by: David Yang <mmyangfl@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20260120092137.2161162-5-mmyangfl@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/vxlan/vxlan_vnifilter.c

index adc89e651e27c8f1a7d95ec107415f6e82a0247c..cde897d92f243fff4a64c1c97795f07a77d6334d 100644 (file)
@@ -126,7 +126,7 @@ static void vxlan_vnifilter_stats_get(const struct vxlan_vni_node *vninode,
                pstats = per_cpu_ptr(vninode->stats, i);
                do {
                        start = u64_stats_fetch_begin(&pstats->syncp);
-                       memcpy(&temp, &pstats->stats, sizeof(temp));
+                       u64_stats_copy(&temp, &pstats->stats, sizeof(temp));
                } while (u64_stats_fetch_retry(&pstats->syncp, start));
 
                dest->rx_packets += temp.rx_packets;