[tftp] Avoid setting current working URI to "tftp://0.0.0.0/"

Set the current working URI to NULL rather than to "tftp://0.0.0.0/".

Reported-by: Piotr Jaroszyński <p.jaroszynski@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>

diff --git a/src/net/udp/tftp.c b/src/net/udp/tftp.c
index f4e9f4c616ca3c51a6363075b0131fb6b4002922..7cd211e41ab8de61df667450078fff9670848e41 100644 (file)
--- a/src/net/udp/tftp.c
+++ b/src/net/udp/tftp.c
@@ -1245,11 +1245,15 @@ static int tftp_apply_settings ( void ) {
         * applicators.
         */
        if ( tftp_server.s_addr != last_tftp_server.s_addr ) {
-               snprintf ( uri_string, sizeof ( uri_string ),
-                          "tftp://%s/", inet_ntoa ( tftp_server ) );
-               uri = parse_uri ( uri_string );
-               if ( ! uri )
-                       return -ENOMEM;
+               if ( tftp_server.s_addr ) {
+                       snprintf ( uri_string, sizeof ( uri_string ),
+                                  "tftp://%s/", inet_ntoa ( tftp_server ) );
+                       uri = parse_uri ( uri_string );
+                       if ( ! uri )
+                               return -ENOMEM;
+               } else {
+                       uri = NULL;
+               }
                churi ( uri );
                uri_put ( uri );
        }