]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c: Fix ICE on deferred pragma in unknown attribute arguments [PR103587]
authorJakub Jelinek <jakub@redhat.com>
Tue, 14 Dec 2021 11:02:55 +0000 (12:02 +0100)
committerJakub Jelinek <jakub@redhat.com>
Tue, 10 May 2022 08:14:30 +0000 (10:14 +0200)
We ICE on the following testcase, because c_parser_balanced_token_sequence
when encountering a deferred pragma will just use c_parser_consume_token
which the FE doesn't allow for CPP_PRAGMA tokens (and if that wasn't
the case, it could ICE on CPP_PRAGMA_EOL similarly).
We don't know in what exact context the pragma appears when we don't
know what those arguments semantically mean, so I think we should just
skip over them, like e.g. the C++ FE does.  And, I think (/[/{ vs. )/]/}
from outside of the pragma shouldn't be paired with those inside of
the pragma and it doesn't seem to be necessary to check that inside of
the pragma line itself all the paren kinds are balanced.

2021-12-14  Jakub Jelinek  <jakub@redhat.com>

PR c/103587
* c-parser.c (c_parser_balanced_token_sequence): For CPP_PRAGMA,
consume the pragma and silently skip to the pragma eol.

* gcc.dg/pr103587.c: New test.

(cherry picked from commit e163dbbc4433e598cad7e6011b255d1d6ad93a3b)

gcc/c/c-parser.c
gcc/testsuite/gcc.dg/pr103587.c [new file with mode: 0644]

index 713dd7740ea8e71292ebebd6ddee82ab0cb63616..2d347ad927c061f50f1e29b19ec3e745b2c6f1d0 100644 (file)
@@ -4812,6 +4812,11 @@ c_parser_balanced_token_sequence (c_parser *parser)
        case CPP_EOF:
          return;
 
+       case CPP_PRAGMA:
+         c_parser_consume_pragma (parser);
+         c_parser_skip_to_pragma_eol (parser, false);
+         break;
+
        default:
          c_parser_consume_token (parser);
          break;
diff --git a/gcc/testsuite/gcc.dg/pr103587.c b/gcc/testsuite/gcc.dg/pr103587.c
new file mode 100644 (file)
index 0000000..1cbc4d5
--- /dev/null
@@ -0,0 +1,7 @@
+/* PR c/103587 */
+/* { dg-do compile } */
+/* { dg-options "" } */
+
+[[foo::bar(
+#pragma GCC ivdep
+)]];   /* { dg-warning "attribute ignored" } */