tail_notify: cleanups and wakeup avoidance

Avoid adding redundant watches at initialization, and avoid
unnecessarily wake ups when no timeout is specified.

diff --git a/lib/PublicInbox/TailNotify.pm b/lib/PublicInbox/TailNotify.pm
index a0347aa5f45e0631a06e5b073a54a4912c57bec7..cbbc1041d3326964d324f64d49254a48efa50ad8 100644 (file)
--- a/lib/PublicInbox/TailNotify.pm
+++ b/lib/PublicInbox/TailNotify.pm
@@ -43,7 +43,6 @@ sub new {
        } else {
                $self->{inot} = PublicInbox::FakeInotify->new;
        }
-       $self->{inot}->watch($fn, $TAIL_MOD);
        reopen_file($self);
        $self->{inot}->watch($fn, $TAIL_MOD);
        $self;
@@ -64,6 +63,8 @@ again:
                        if (defined $end) {
                                $wait = $end - now;
                                $wait = 0 if $wait < 0;
+                       } else {
+                               undef $wait;
                        }
                }
                select($rfds, undef, undef, $wait);