]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
of: Move of_prop_val_eq() next to the single user
authorRob Herring (Arm) <robh@kernel.org>
Wed, 12 Mar 2025 21:29:46 +0000 (16:29 -0500)
committerRob Herring (Arm) <robh@kernel.org>
Fri, 14 Mar 2025 23:01:42 +0000 (18:01 -0500)
There's only a single user of of_prop_val_eq(), so move it to overlay.c.
This removes one case of exposing struct property outside of the DT
code.

Signed-off-by: "Rob Herring (Arm)" <robh@kernel.org>
Link: https://lore.kernel.org/r/20250312212947.1067337-1-robh@kernel.org
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
drivers/of/overlay.c
include/linux/of.h

index 5a51c52b9729af2ab77b5a9365cb72d30740f3b0..1af6f52d0708fdb92286fc9502e2132dcb5758d0 100644 (file)
@@ -84,6 +84,12 @@ static int devicetree_state_flags;
 #define DTSF_APPLY_FAIL                0x01
 #define DTSF_REVERT_FAIL       0x02
 
+static int of_prop_val_eq(const struct property *p1, const struct property *p2)
+{
+       return p1->length == p2->length &&
+              !memcmp(p1->value, p2->value, (size_t)p1->length);
+}
+
 /*
  * If a changeset apply or revert encounters an error, an attempt will
  * be made to undo partial changes, but may fail.  If the undo fails
index 86bf8f0731112456b3efc2e5ee00e73000c6af56..e95a02db321a4ad7fe35b20f1238c29c0e0073e0 100644 (file)
@@ -908,12 +908,6 @@ static inline const void *of_device_get_match_data(const struct device *dev)
 #define of_node_cmp(s1, s2)            strcasecmp((s1), (s2))
 #endif
 
-static inline int of_prop_val_eq(const struct property *p1, const struct property *p2)
-{
-       return p1->length == p2->length &&
-              !memcmp(p1->value, p2->value, (size_t)p1->length);
-}
-
 #define for_each_property_of_node(dn, pp) \
        for (pp = dn->properties; pp != NULL; pp = pp->next)