]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Improvements to test_computed_col_default_not_set 5417/head
authorRafi Shamim <rafi@cockroachlabs.com>
Tue, 23 Jun 2020 18:20:54 +0000 (14:20 -0400)
committerRafi Shamim <rafi@cockroachlabs.com>
Thu, 9 Jul 2020 04:51:46 +0000 (00:51 -0400)
- Update the test so it looks at computed_default_table instead of
  computed_column_table.
- Stop inspecting autoincrement; instead directly check for
  default/non-default values for the relevant columns.

Fixes: #5414
lib/sqlalchemy/testing/suite/test_reflection.py

index 7080888813e63b4d5abce1159a1c07a84b7c7783..84b3aba5be4d1f4b5164c043ffae058e4edbd116 100644 (file)
@@ -1171,12 +1171,11 @@ class ComputedReflectionTest(fixtures.ComputedReflectionFixtureTest):
     def test_computed_col_default_not_set(self):
         insp = inspect(config.db)
 
-        cols = insp.get_columns("computed_column_table")
-        for col in cols:
-            if col["name"] == "with_default":
-                is_true("42" in col["default"])
-            elif not col["autoincrement"]:
-                is_(col["default"], None)
+        cols = insp.get_columns("computed_default_table")
+        col_data = {c["name"]: c for c in cols}
+        is_true("42" in col_data["with_default"]["default"])
+        is_(col_data["normal"]["default"], None)
+        is_(col_data["computed_col"]["default"], None)
 
     def test_get_column_returns_computed(self):
         insp = inspect(config.db)