cgget: Fix strncpy() truncation warning

Fix the following strncpy() string truncation warning:

In function ‘strncat’,
    inlined from ‘fill_empty_controller’ at cgget.c:584:2:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:136:10: warning: ‘__builtin___strncat_chk’ output may be truncated copying between 0 and 4095 bytes from a string of length 4095 [-Wstringop-truncation]
  136 |   return __builtin___strncat_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/tools/cgget.c b/src/tools/cgget.c
index 769ef9270006d411e65f260474f2aaff5601f9f6..e9e29fd2350e8d01ff52401e7fe44ed1eac533ff 100644 (file)
--- a/src/tools/cgget.c
+++ b/src/tools/cgget.c
@@ -582,6 +582,7 @@ static int fill_empty_controller(struct cgroup * const cg,
 
        path_len = strlen(path);
        strncat(path, cg->name, FILENAME_MAX - path_len - 1);
+       path[sizeof(path) - 1] = '\0';
 
        if (access(path, F_OK))
                goto out;