cls: check data before memcpy() it

[thaller@redhat.com: I modified the condition "if (data && len)"
 in the original patch to just check "len > 0".
 Note that all call sites of meta_alloc() make sure to pass a
 valid data pointer with a non-zero length (anything else would
 be a bug). But indeed, calling memcpy with invalid src pointer
 is undefined behavior, even if len is zero.]

Signed-off-by: Thomas Haller <thaller@redhat.com>

diff --git a/lib/route/cls/ematch/meta.c b/lib/route/cls/ematch/meta.c
index 6249bb13586d588f3ae7d8b6632dc95e9c02e6d0..e33c405a98ee206e6d6b444056cbddb8f337f840 100644 (file)
--- a/lib/route/cls/ematch/meta.c
+++ b/lib/route/cls/ematch/meta.c
@@ -51,7 +51,8 @@ static struct rtnl_meta_value *meta_alloc(uint8_t type, uint16_t id,
        value->mv_shift = shift;
        value->mv_len = len;
 
-       memcpy(value + 1, data, len);
+       if (len)
+               memcpy(value + 1, data, len);
 
        return value;
 }