]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: enetc: do not print error log if addr is 0
authorWei Fang <wei.fang@nxp.com>
Mon, 22 Dec 2025 02:26:28 +0000 (10:26 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Dec 2025 10:30:41 +0000 (11:30 +0100)
A value of 0 for addr indicates that the IEB_LBCR register does not
need to be configured, as its default value is 0. However, the driver
will print an error log if addr is 0, so this issue needs to be fixed.

Fixes: 50bfd9c06f0f ("net: enetc: set external PHY address in IERB for i.MX94 ENETC")
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251222022628.4016403-1-wei.fang@nxp.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/freescale/enetc/netc_blk_ctrl.c

index 443983fdecd959be29fb034b4280026f7db29697..7fd39f89529014aa5f09378c39bfb6589f2868c6 100644 (file)
@@ -577,11 +577,17 @@ static int imx94_enetc_mdio_phyaddr_config(struct netc_blk_ctrl *priv,
        }
 
        addr = netc_get_phy_addr(np);
-       if (addr <= 0) {
+       if (addr < 0) {
                dev_err(dev, "Failed to get PHY address\n");
                return addr;
        }
 
+       /* The default value of LaBCR[MDIO_PHYAD_PRTAD] is 0,
+        * so no need to set the register.
+        */
+       if (!addr)
+               return 0;
+
        if (phy_mask & BIT(addr)) {
                dev_err(dev,
                        "Find same PHY address in EMDIO and ENETC node\n");