]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
tlsstore: remove ThreadExitPrintStats callback
authorJason Ish <jason.ish@oisf.net>
Thu, 29 Aug 2024 20:33:42 +0000 (14:33 -0600)
committerVictor Julien <victor@inliniac.net>
Sat, 31 Aug 2024 08:53:59 +0000 (10:53 +0200)
Remove the callback to print stats on thread exit.  The counter value
was never being used and this helps us get rid of this callback
altogether as their is only one other usage of it.

Ticket: #7227

src/log-tlsstore.c

index e6c89559ed4d6351a095b46c3947b04ae93018df..4e7ed98b772403f2f336f6b1d2cbcb06c7e85236 100644 (file)
@@ -50,8 +50,6 @@ static char logging_dir_not_writable;
 #define LOGGING_WRITE_ISSUE_LIMIT 6
 
 typedef struct LogTlsStoreLogThread_ {
-    uint32_t tls_cnt;
-
     uint8_t*   enc_buf;
     size_t     enc_buf_len;
 } LogTlsStoreLogThread;
@@ -384,16 +382,6 @@ static TmEcode LogTlsStoreLogThreadDeinit(ThreadVars *t, void *data)
     return TM_ECODE_OK;
 }
 
-static void LogTlsStoreLogExitPrintStats(ThreadVars *tv, void *data)
-{
-    LogTlsStoreLogThread *aft = (LogTlsStoreLogThread *)data;
-    if (aft == NULL) {
-        return;
-    }
-
-    SCLogInfo("(%s) certificates extracted %" PRIu32 "", tv->name, aft->tls_cnt);
-}
-
 /**
  *  \internal
  *
@@ -447,14 +435,13 @@ static OutputInitResult LogTlsStoreLogInitCtx(ConfNode *conf)
 
 void LogTlsStoreRegister (void)
 {
-    OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE, MODULE_NAME,
-        "tls-store", LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLogger,
-        LogTlsStoreCondition, LogTlsStoreLogThreadInit,
-        LogTlsStoreLogThreadDeinit, LogTlsStoreLogExitPrintStats);
+    OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE, MODULE_NAME, "tls-store",
+            LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLogger, LogTlsStoreCondition,
+            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, NULL);
 
     OutputRegisterTxModuleWithCondition(LOGGER_TLS_STORE_CLIENT, MODULE_NAME, "tls-store",
             LogTlsStoreLogInitCtx, ALPROTO_TLS, LogTlsStoreLoggerClient, LogTlsStoreConditionClient,
-            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, LogTlsStoreLogExitPrintStats);
+            LogTlsStoreLogThreadInit, LogTlsStoreLogThreadDeinit, NULL);
 
     SC_ATOMIC_INIT(cert_id);
     SC_ATOMIC_SET(cert_id, 1);