]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: sunxi: use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 12 Jun 2025 13:15:23 +0000 (15:15 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 18 Jun 2025 12:08:38 +0000 (14:08 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/20250612-gpiochip-set-rv-pinctrl-remaining-v1-14-556b0a530cd4@linaro.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sunxi/pinctrl-sunxi.c

index a090d78a34135491a9d3b28fa083980483e7d562..a5ce84621e5a86efd20a3b97de71eabcd42fec6a 100644 (file)
@@ -955,8 +955,8 @@ static int sunxi_pinctrl_gpio_get(struct gpio_chip *chip, unsigned offset)
        return val;
 }
 
-static void sunxi_pinctrl_gpio_set(struct gpio_chip *chip,
-                               unsigned offset, int value)
+static int sunxi_pinctrl_gpio_set(struct gpio_chip *chip, unsigned int offset,
+                                 int value)
 {
        struct sunxi_pinctrl *pctl = gpiochip_get_data(chip);
        u32 reg, shift, mask, val;
@@ -976,6 +976,8 @@ static void sunxi_pinctrl_gpio_set(struct gpio_chip *chip,
        writel(val, pctl->membase + reg);
 
        raw_spin_unlock_irqrestore(&pctl->lock, flags);
+
+       return 0;
 }
 
 static int sunxi_pinctrl_gpio_direction_output(struct gpio_chip *chip,
@@ -1597,7 +1599,7 @@ int sunxi_pinctrl_init_with_flags(struct platform_device *pdev,
        pctl->chip->direction_input = sunxi_pinctrl_gpio_direction_input;
        pctl->chip->direction_output = sunxi_pinctrl_gpio_direction_output;
        pctl->chip->get = sunxi_pinctrl_gpio_get;
-       pctl->chip->set = sunxi_pinctrl_gpio_set;
+       pctl->chip->set_rv = sunxi_pinctrl_gpio_set;
        pctl->chip->of_xlate = sunxi_pinctrl_gpio_of_xlate;
        pctl->chip->to_irq = sunxi_pinctrl_gpio_to_irq;
        pctl->chip->of_gpio_n_cells = 3;