]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
dlm: Constify struct configfs_item_operations and configfs_group_operations
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 20 Jan 2026 15:35:08 +0000 (10:35 -0500)
committerDavid Teigland <teigland@redhat.com>
Tue, 20 Jan 2026 18:07:31 +0000 (12:07 -0600)
'struct configfs_item_operations' and 'configfs_group_operations' are not
modified in this driver.

Constifying these structures moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig, as an example:
Before:
======
   text    data     bss     dec     hex filename
  29436   12952     384   42772    a714 fs/dlm/config.o

After:
=====
   text    data     bss     dec     hex filename
  30076   12312     384   42772    a714 fs/dlm/config.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/config.c

index a0d75b5c83c63266113a0ca051c56b7b1008b1f2..82cc3215663f6f55861bbf68cbd8234f438fcfd1 100644 (file)
@@ -324,39 +324,39 @@ struct dlm_member_gone {
        struct list_head list; /* space->members_gone */
 };
 
-static struct configfs_group_operations clusters_ops = {
+static const struct configfs_group_operations clusters_ops = {
        .make_group = make_cluster,
        .drop_item = drop_cluster,
 };
 
-static struct configfs_item_operations cluster_ops = {
+static const struct configfs_item_operations cluster_ops = {
        .release = release_cluster,
 };
 
-static struct configfs_group_operations spaces_ops = {
+static const struct configfs_group_operations spaces_ops = {
        .make_group = make_space,
        .drop_item = drop_space,
 };
 
-static struct configfs_item_operations space_ops = {
+static const struct configfs_item_operations space_ops = {
        .release = release_space,
 };
 
-static struct configfs_group_operations comms_ops = {
+static const struct configfs_group_operations comms_ops = {
        .make_item = make_comm,
        .drop_item = drop_comm,
 };
 
-static struct configfs_item_operations comm_ops = {
+static const struct configfs_item_operations comm_ops = {
        .release = release_comm,
 };
 
-static struct configfs_group_operations nodes_ops = {
+static const struct configfs_group_operations nodes_ops = {
        .make_item = make_node,
        .drop_item = drop_node,
 };
 
-static struct configfs_item_operations node_ops = {
+static const struct configfs_item_operations node_ops = {
        .release = release_node,
 };