]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_passt: Report error when getting passt PID failed
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 13 Feb 2023 15:05:04 +0000 (16:05 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 15 Feb 2023 15:21:26 +0000 (16:21 +0100)
If qemuPasstGetPid() fails, or the passt's PID is -1 then
qemuPasstSetupCgroup() returns early without any error message
set. Report an appropriate error.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/qemu/qemu_passt.c

index 0f09bf3db86a031390cd3699a697a7c4b4cfd702..78830fdc26e8039a09dd3d08222b04cd0a18d7c7 100644 (file)
@@ -125,8 +125,11 @@ qemuPasstSetupCgroup(virDomainObj *vm,
 {
     pid_t pid = (pid_t) -1;
 
-    if (qemuPasstGetPid(vm, net, &pid) < 0 || pid <= 0)
+    if (qemuPasstGetPid(vm, net, &pid) < 0 || pid <= 0) {
+        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                       _("Could not get process ID of passt"));
         return -1;
+    }
 
     return virCgroupAddProcess(cgroup, pid);
 }