]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
document a PAM spec problem in a frustrated comment
authorDamien Miller <djm@mindrot.org>
Fri, 26 Jun 2020 06:07:12 +0000 (16:07 +1000)
committerDamien Miller <djm@mindrot.org>
Fri, 26 Jun 2020 06:07:24 +0000 (16:07 +1000)
auth-pam.c

index 5a3ba09b43d31907575e89877bc92462d7bb9da1..83238215127453c6558f78284f3d153e465b2e10 100644 (file)
@@ -375,7 +375,11 @@ import_environments(struct sshbuf *b)
                        error("PAM: pam_putenv: %s",
                            pam_strerror(sshpam_handle, r));
                }
-               /* XXX leak env? */
+               /*
+                * XXX this possibly leaks env because it is not documented
+                * what pam_putenv() does with it. Does it copy it? Does it
+                * take ownweship? We don't know, so it's safest just to leak.
+                */
        }
 #endif
 }