]> git.ipfire.org Git - thirdparty/grub.git/commitdiff
squash4: Fix an uninitialized variable
authorPeter Jones <pjones@redhat.com>
Mon, 27 Jan 2020 20:01:16 +0000 (15:01 -0500)
committerDaniel Kiper <daniel.kiper@oracle.com>
Tue, 28 Jan 2020 20:22:01 +0000 (21:22 +0100)
gcc says:

grub-core/fs/squash4.c: In function ‘direct_read’:
grub-core/fs/squash4.c:868:10: error: ‘err’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
  868 |       if (err)
      |          ^
cc1: all warnings being treated as errors

This patch initializes it to GRUB_ERR_NONE.

Signed-off-by: Peter Jones <pjones@redhat.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
grub-core/fs/squash4.c

index 95d5c1e1ff482a5f2b3dd9ea582793a1aa36bcd8..82704f966bd0c968e983784d26fa7fcdc2dfbf44 100644 (file)
@@ -746,7 +746,7 @@ direct_read (struct grub_squash_data *data,
             struct grub_squash_cache_inode *ino,
             grub_off_t off, char *buf, grub_size_t len)
 {
-  grub_err_t err;
+  grub_err_t err = GRUB_ERR_NONE;
   grub_off_t cumulated_uncompressed_size = 0;
   grub_uint64_t a = 0;
   grub_size_t i;