ethernet: tundra: free irq when alloc ring failed in tsi108_open()

[ Upstream commit acce40037041f97baad18142bb253064491ebde3 ]

When alloc tx/rx ring failed in tsi108_open(), it doesn't free irq. Fix
it.

Fixes: 5e123b844a1c ("[PATCH] Add tsi108/9 On Chip Ethernet device driver support")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221109044016.126866-1-shaozhengchao@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/ethernet/tundra/tsi108_eth.c b/drivers/net/ethernet/tundra/tsi108_eth.c
index c62f474b6d08eb74c159811c9ea32549845072e9..fcebd2418dbd3b3e2b8942ce211e699d146ef7c4 100644 (file)
--- a/drivers/net/ethernet/tundra/tsi108_eth.c
+++ b/drivers/net/ethernet/tundra/tsi108_eth.c
@@ -1302,12 +1302,15 @@ static int tsi108_open(struct net_device *dev)
 
        data->rxring = dma_alloc_coherent(&data->pdev->dev, rxring_size,
                                          &data->rxdma, GFP_KERNEL);
-       if (!data->rxring)
+       if (!data->rxring) {
+               free_irq(data->irq_num, dev);
                return -ENOMEM;
+       }
 
        data->txring = dma_alloc_coherent(&data->pdev->dev, txring_size,
                                          &data->txdma, GFP_KERNEL);
        if (!data->txring) {
+               free_irq(data->irq_num, dev);
                dma_free_coherent(&data->pdev->dev, rxring_size, data->rxring,
                                    data->rxdma);
                return -ENOMEM;