]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix error handling in krb5_walk_realm_tree
authorGreg Hudson <ghudson@mit.edu>
Fri, 6 Feb 2009 18:40:04 +0000 (18:40 +0000)
committerGreg Hudson <ghudson@mit.edu>
Fri, 6 Feb 2009 18:40:04 +0000 (18:40 +0000)
rtree_hier_realms was forgetting to assign the return value of
krb5int_copy_data_contents to retval, which would cause a failure to
notice out-of-memory conditions.

ticket: 6375
tags: pullup
target_version: 1.7

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21909 dc483132-0cff-0310-8789-dd5450dbe970

src/lib/krb5/krb/walk_rtree.c

index 4cebce5267c19bb1688e845787fea6cfcda3984f..ba15489d608f1b3543e9b68318f3f40c6c7eeaf3 100644 (file)
@@ -389,7 +389,7 @@ rtree_hier_realms(
     }
     /* Copy server realm "tweens" backward. */
     for (twp = &stweens[nstween]; twp-- > stweens;) {
-       krb5int_copy_data_contents(context, twp, rp++);
+       retval = krb5int_copy_data_contents(context, twp, rp++);
        if (retval) goto error;
     }
 error: