]> git.ipfire.org Git - thirdparty/dnspython.git/commitdiff
Add entries to the resolution errors list in a few error cases that were omitted.
authorBob Halley <halley@dnspython.org>
Fri, 23 Apr 2021 22:26:33 +0000 (15:26 -0700)
committerBob Halley <halley@dnspython.org>
Fri, 23 Apr 2021 22:26:33 +0000 (15:26 -0700)
dns/resolver.py

index 7bdfd91fc3be896d9f7040a3b418dd15ba3fba1c..8d7c80569610db3aea432d7c9be9014335f31f7c 100644 (file)
@@ -663,7 +663,9 @@ class _Resolution:
             try:
                 answer = Answer(self.qname, self.rdtype, self.rdclass, response,
                                 self.nameserver, self.port)
-            except Exception:
+            except Exception as e:
+                self.errors.append((self.nameserver, self.tcp_attempt,
+                                   self.port, e, response))
                 # The nameserver is no good, take it out of the mix.
                 self.nameservers.remove(self.nameserver)
                 return (None, False)
@@ -679,7 +681,9 @@ class _Resolution:
             try:
                 answer = Answer(self.qname, dns.rdatatype.ANY,
                                 dns.rdataclass.IN, response)
-            except Exception:
+            except Exception as e:
+                self.errors.append((self.nameserver, self.tcp_attempt,
+                                   self.port, e, response))
                 # The nameserver is no good, take it out of the mix.
                 self.nameservers.remove(self.nameserver)
                 return (None, False)