]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
tweak code to satisfy coverity #1633838
authorAlan T. DeKok <aland@freeradius.org>
Sat, 11 Jan 2025 15:04:01 +0000 (10:04 -0500)
committerAlan T. DeKok <aland@freeradius.org>
Sun, 12 Jan 2025 14:51:10 +0000 (09:51 -0500)
src/protocols/radius/encode.c

index 9656d434fa75250d9dd150cb800389c62cb23b47..e4b0151a1d66f63084bea97bed382f1bdf6d275e 100644 (file)
@@ -331,7 +331,6 @@ static ssize_t encode_value(fr_dbuff_t *dbuff,
        fr_dbuff_t                      value_dbuff;
        fr_dbuff_marker_t               value_start, src, dest;
        bool                            encrypted = false;
-       fr_radius_attr_flags_encrypt_t  encrypt;
 
        PAIR_VERIFY(vp);
        FR_PROTO_STACK_PRINT(da_stack, depth);
@@ -493,8 +492,7 @@ static ssize_t encode_value(fr_dbuff_t *dbuff,
         *      Attributes with encrypted values MUST be less than
         *      128 bytes long.
         */
-       encrypt = fr_radius_flag_encrypted(da);
-       if (encrypt) switch (encrypt) {
+       switch (fr_radius_flag_encrypted(da)) {
        case RADIUS_FLAG_ENCRYPT_USER_PASSWORD:
                /*
                 *      Encode the password in place