]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
Revert "drm/mipi-dsi: Set the fwnode for mipi_dsi_device"
authorJason-JH.Lin <jason-jh.lin@mediatek.com>
Tue, 29 Oct 2024 01:24:53 +0000 (09:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Nov 2024 15:25:56 +0000 (16:25 +0100)
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200 which is
commit a26cc2934331b57b5a7164bff344f0a2ec245fc0 upstream.

Reason for revert:
1. The commit [1] does not land on linux-5.15, so this patch does not
fix anything.

2. Since the fw_devlink improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during
bootup.

Incorrect link management may lead to incorrect device initialization,
affecting firmware node links and consumer relationships.
The fwnode setting of panel to the DSI device would cause a DSI
initialization error without series[2], so this patch was reverted to
avoid using the incomplete fw_devlink functionality.

[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust")
Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Cc: stable@vger.kernel.org # 5.15.169
Cc: stable@vger.kernel.org # 5.10.228
Cc: stable@vger.kernel.org # 5.4.284
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_mipi_dsi.c

index 24606b632009e91e7fded22d926a5495e65d3c12..468a3a7cb6a5193a390b52c3a85a19f3ca83e6cf 100644 (file)
@@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host,
                return dsi;
        }
 
-       device_set_node(&dsi->dev, of_fwnode_handle(info->node));
+       dsi->dev.of_node = info->node;
        dsi->channel = info->channel;
        strlcpy(dsi->name, info->type, sizeof(dsi->name));