usb: typec: altmodes/displayport: Drop the device reference in dp_altmode_probe()

commit 128bb7fab342546352603bde8b49ff54e3af0529 upstream.

In error paths, call typec_altmode_put_plug() to drop the device reference
obtained by typec_altmode_get_plug().

Fixes: 71ba4fe56656 ("usb: typec: altmodes/displayport: add SOP' support")
Cc: stable <stable@kernel.org>
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20251206070445.190770-1-lihaoxiang@isrc.iscas.ac.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index 6964f403a2d535001ca47f215e96ad3f51438147..67cb974ec76172d1e50c230b9e1bd1e51cc73bc4 100644 (file)
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -736,12 +736,16 @@ int dp_altmode_probe(struct typec_altmode *alt)
        if (!(DP_CAP_PIN_ASSIGN_DFP_D(port->vdo) &
              DP_CAP_PIN_ASSIGN_UFP_D(alt->vdo)) &&
            !(DP_CAP_PIN_ASSIGN_UFP_D(port->vdo) &
-             DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo)))
+             DP_CAP_PIN_ASSIGN_DFP_D(alt->vdo))) {
+               typec_altmode_put_plug(plug);
                return -ENODEV;
+       }
 
        dp = devm_kzalloc(&alt->dev, sizeof(*dp), GFP_KERNEL);
-       if (!dp)
+       if (!dp) {
+               typec_altmode_put_plug(plug);
                return -ENOMEM;
+       }
 
        INIT_WORK(&dp->work, dp_altmode_work);
        mutex_init(&dp->lock);