[907-remove-kea-thread-library] Addressed comments

diff --git a/doc/devel/Doxyfile b/doc/devel/Doxyfile
index c3960acffd7167ee0ef537c64b0adf4daf66bfb1..5032a8832522b56094dd593aff2b4c285990f606 100644 (file)
--- a/doc/devel/Doxyfile
+++ b/doc/devel/Doxyfile
@@ -814,7 +814,6 @@ INPUT                  = ../../src/bin/agent \
                          ../../src/lib/util/encode \
                          ../../src/lib/util/io \
                          ../../src/lib/util/random \
-                         ../../src/lib/util/threads \
                          ../../src/lib/util/unittests \
                          ../../src/lib/yang \
                          .

diff --git a/doc/devel/congestion-handling.dox b/doc/devel/congestion-handling.dox
index 058a3a7f41ecfa15399168b696bb001cd0416f63..e5e44fe8152ed597b5241eb1f383e1bb6b6374fd 100644 (file)
--- a/doc/devel/congestion-handling.dox
+++ b/doc/devel/congestion-handling.dox
@@ -1,4 +1,4 @@
-// Copyright (C) 2018 Internet Systems Consortium, Inc. ("ISC")
+// Copyright (C) 2018-2019 Internet Systems Consortium, Inc. ("ISC")
 //
 // This Source Code Form is subject to the terms of the Mozilla Public
 // License, v. 2.0. If a copy of the MPL was not distributed with this
@@ -111,8 +111,7 @@ isc::dhcp::PacketQueueRing6).  The most critical aspects to remember when
 developing your implementation are:
 
 -# It MUST be thread safe since queuing and dequeing packets are done by
-separate threads. (You might considering using isc::util::thread::Mutex and
-isc::util::thread::Mutex::Locker).
+separate threads. (You might considering using std::mutex and std::lock_guard).
 
 -# Its efficiency (or lack thereof) will have a direct impact on server
 performance.  You will have to consider the dynamics of your deployment

diff --git a/src/hooks/dhcp/high_availability/tests/ha_test.h b/src/hooks/dhcp/high_availability/tests/ha_test.h
index 169a7281d371920d502fa22534257b552fbfedba..ab1487f1cf812d9a18b198ed4d48bd121b52dfe9 100644 (file)
--- a/src/hooks/dhcp/high_availability/tests/ha_test.h
+++ b/src/hooks/dhcp/high_availability/tests/ha_test.h
@@ -22,6 +22,7 @@
 #include <string>
 #include <vector>
 #include <mutex>
+#include <condition_variable>
 #include <thread>
 
 namespace isc {

diff --git a/src/lib/testutils/threaded_test.h b/src/lib/testutils/threaded_test.h
index 1ff4909c2ec0eb1245a06d42a970294b72acc0f6..7b0a97287141c5748b8a0df6826711a25c647be1 100644 (file)
--- a/src/lib/testutils/threaded_test.h
+++ b/src/lib/testutils/threaded_test.h
@@ -11,6 +11,7 @@
 #include <gtest/gtest.h>
 #include <thread>
 #include <mutex>
+#include <condition_variable>
 
 namespace isc {
 namespace test {